Build datastore index resource. #3085

nat-henderson · 2020-02-06T03:16:12Z

Add datastore/ product
Add ability for fetching resources from operations
Fixes hashicorp/terraform-provider-google#60

Release Note Template for Downstream PRs (will be copied)

google_datastore_index

modular-magician · 2020-02-06T03:22:31Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 26 files changed, 763 insertions(+), 47 deletions(-))
Terraform Beta: Diff ( 31 files changed, 794 insertions(+), 56 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))

nat-henderson · 2020-02-06T03:25:32Z

Haven't written examples yet, sending out for early review to make sure I'm headed down the right road. Works in testing on my machine!

modular-magician · 2020-02-06T03:27:37Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 26 files changed, 763 insertions(+), 47 deletions(-))
Terraform Beta: Diff ( 31 files changed, 794 insertions(+), 56 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))

modular-magician · 2020-02-07T21:09:38Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 26 files changed, 996 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 30 files changed, 1070 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))

modular-magician · 2020-02-07T21:21:50Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 26 files changed, 996 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 30 files changed, 1070 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))

modular-magician · 2020-02-07T21:59:50Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 1108 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 31 files changed, 1182 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))
TF OiCS: Diff ( 2 files changed, 110 insertions(+))

nat-henderson · 2020-02-07T22:04:21Z

@danawillow Okay, seems to be working for me, ready for review!

products/datastore/api.yaml

products/datastore/terraform.yaml

products/datastore/api.yaml

products/datastore/terraform.yaml

products/datastore/api.yaml

danawillow · 2020-02-07T23:38:09Z

templates/terraform/resource.erb

@@ -234,8 +234,39 @@ func resource<%= resource_name -%>Create(d *schema.ResourceData, meta interface{
    }
 <%    end -%>
 <%    if object.async.is_a? Api::OpAsync -%>
+    <% if object.async.result.resource_inside_response and not object.identity.empty? -%>


Just to check- is the index id not known until the operation is finished, or is it also contained in the first operation that we then poll? I know firestore_index currently solves this with custom code in the post create, because the name is contained in the first operation response that we already have. Looking at the generated output for this we now set the id on that resource 3 times in create, which isn't ideal. Is there a clean solution that would work for that resource and this?

That's right - it's not known until the operation is finished. :( I saw that it could be solved with custom code, but I wanted to make sure that I solved it Once And For All - is there an issue with setting the ID three times? I think we set it once to make sure that we'll do a refresh if we fail in the middle of polling, plus once to get the true final id once all information is known ... and then in firestore, once more due to the custom code solution. I agree it's not clean, and I'm struggling to test it so I don't even know if it works yet (since you can't use the same project for both firestore and datastore).

Got it. I'm pretty ok with it, then. It shouldn't cause issues for users and especially with these templates going away at some point, I don't think it's worth spending a ton of time finding the most-clean-code way to solve this problem for two resources with similar but not identical needs.

nat-henderson · 2020-02-08T00:54:41Z

Resolved all comments but one - the uncleanliness of this solution when combined with Firestore's solution for a similar, but different, problem. I can try to find something, but at first glance it's not obvious how to avoid it, other than making this operation change into custom code. I resolve that tradeoff in this direction, but I'm willing to change it - is it worth it, in your opinion?

modular-magician · 2020-02-08T01:02:07Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 26 files changed, 994 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 30 files changed, 1068 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))
TF OiCS: Diff ( 2 files changed, 110 insertions(+))

modular-magician · 2020-02-10T23:26:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 1003 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 31 files changed, 1077 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))
TF OiCS: Diff ( 2 files changed, 110 insertions(+))

Add datastore/ product Add ability for fetching resources from operations

… port old code over to.

modular-magician · 2020-02-11T00:02:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 1003 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 31 files changed, 1077 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))
TF OiCS: Diff ( 2 files changed, 110 insertions(+))

modular-magician · 2020-02-11T00:48:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 1012 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 31 files changed, 1088 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))
TF OiCS: Diff ( 2 files changed, 110 insertions(+))

modular-magician · 2020-02-11T01:31:18Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 27 files changed, 1012 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 31 files changed, 1088 insertions(+), 48 deletions(-))
TF Conversion: Diff ( 2 files changed, 110 insertions(+))
TF OiCS: Diff ( 2 files changed, 110 insertions(+))

googlebot added the cla: yes label Feb 6, 2020

nat-henderson requested a review from danawillow February 6, 2020 03:24

nat-henderson force-pushed the datastore-index branch from 599fccb to c180935 Compare February 7, 2020 21:03

nat-henderson force-pushed the datastore-index branch from c180935 to 09ef2e2 Compare February 7, 2020 21:14

nat-henderson force-pushed the datastore-index branch from 09ef2e2 to 191194a Compare February 7, 2020 21:53

danawillow suggested changes Feb 7, 2020

View reviewed changes

nat-henderson force-pushed the datastore-index branch from babb8c7 to 03ee74d Compare February 10, 2020 23:20

danawillow approved these changes Feb 10, 2020

View reviewed changes

nat-henderson added 6 commits February 10, 2020 15:57

Build datastore index resource.

778ab9e

Add datastore/ product Add ability for fetching resources from operations

add copyright notices.

2257cfe

Switch to creating a new method - this was getting too complicated to…

d5a1bce

… port old code over to.

Add examples.

c34fefc

Add documentation, update years, disable sweeper.

dc31d89

Remove some unnecessary overrides, add google.erb.

ef337a3

nat-henderson force-pushed the datastore-index branch from 03ee74d to ef337a3 Compare February 10, 2020 23:58

Add a nolint for a potentially unused method.

11cc3b6

nat-henderson force-pushed the datastore-index branch from be5fabb to 11cc3b6 Compare February 11, 2020 01:26

nat-henderson merged commit 526f68f into GoogleCloudPlatform:master Feb 12, 2020

This was referenced Feb 12, 2020

Build datastore index resource. hashicorp/terraform-provider-google#5655

Merged

Build datastore index resource. hashicorp/terraform-provider-google-beta#1755

Merged

This was referenced Feb 18, 2020

Fix TestAccAccessContextManager hashicorp/terraform-provider-google#5704

Closed

Add decoder after OperationWaitTimeWithResponse #3146

Merged

nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020

Build datastore index resource. (GoogleCloudPlatform#3085)

1f3c790

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build datastore index resource. #3085

Build datastore index resource. #3085

nat-henderson commented Feb 6, 2020 •

edited by emilymye

Loading

modular-magician commented Feb 6, 2020

nat-henderson commented Feb 6, 2020

modular-magician commented Feb 6, 2020

modular-magician commented Feb 7, 2020

modular-magician commented Feb 7, 2020

modular-magician commented Feb 7, 2020

nat-henderson commented Feb 7, 2020

danawillow Feb 7, 2020

nat-henderson Feb 8, 2020

danawillow Feb 10, 2020

nat-henderson commented Feb 8, 2020

modular-magician commented Feb 8, 2020

modular-magician commented Feb 10, 2020

modular-magician commented Feb 11, 2020

modular-magician commented Feb 11, 2020

modular-magician commented Feb 11, 2020

Build datastore index resource. #3085

Build datastore index resource. #3085

Conversation

nat-henderson commented Feb 6, 2020 • edited by emilymye Loading

modular-magician commented Feb 6, 2020

Diff report:

nat-henderson commented Feb 6, 2020

modular-magician commented Feb 6, 2020

Diff report:

modular-magician commented Feb 7, 2020

Diff report:

modular-magician commented Feb 7, 2020

Diff report:

modular-magician commented Feb 7, 2020

Diff report:

nat-henderson commented Feb 7, 2020

danawillow Feb 7, 2020

Choose a reason for hiding this comment

nat-henderson Feb 8, 2020

Choose a reason for hiding this comment

danawillow Feb 10, 2020

Choose a reason for hiding this comment

nat-henderson commented Feb 8, 2020

modular-magician commented Feb 8, 2020

Diff report:

modular-magician commented Feb 10, 2020

Diff report:

modular-magician commented Feb 11, 2020

Diff report:

modular-magician commented Feb 11, 2020

Diff report:

modular-magician commented Feb 11, 2020

Diff report:

nat-henderson commented Feb 6, 2020 •

edited by emilymye

Loading